Merged
Conversation
|
This fix miss these conditions: -- you need to check ft_handler(...).linter
ft('foo'):fmt(...)
ft('*'):lint(...)
-- merge two linter list
ft('foo'):lint(...)
ft('*'):lint(...) |
|
I'm not really sure whether this fix is elegant. local buf_config = ft_handler[vim.bo[buf].filetype]
local generic_config = ft_handler['*']
if not (buf_config or generic_config) then
return
end
local linters = buf_config.linter or {}
if generic_config.linter then
vim.list_extend(linters, generic_config.linter)
end |
Member
Author
If it doesn't modify the original table then it seems fine. |
|
This is an uglier solution 🤣 local buf_config = ft_handler[vim.bo[buf].filetype]
local generic_config = ft_handler['*']
local linters = {}
if buf_config and buf_config.linter then
vim.list_extend(linters, buf_config.linter)
end
if generic_config and generic_config.linter then
vim.list_extend(linters, generic_config.linter)
end
if #linters == 0 then
return
end |
Member
Author
|
Hmm, actually we should have a pre-condition that buf_config.linter is not nil or this autocmd wouldn't have been registered in the first place. But it is possible the configuration tables are modified during runtime, anyway, this deserves a refactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #132