Skip to content

feat: add save_on_fmt setup option#88

Merged
xiaoshihou514 merged 5 commits intonvimdev:mainfrom
ej-shafran:main
Feb 9, 2024
Merged

feat: add save_on_fmt setup option#88
xiaoshihou514 merged 5 commits intonvimdev:mainfrom
ej-shafran:main

Conversation

@ej-shafran
Copy link
Copy Markdown
Contributor

Relevant to #8

Couldn't figure out a simple way to add save_on_fmt as an option in setup without making a giant mess of things, settled on adding a GuardFmtNoSave command that just calls do_fmt with false for a save_on_fmt parameter.

@glepnir
Copy link
Copy Markdown
Member

glepnir commented Aug 31, 2023

could we add a new option for this ?

@ej-shafran
Copy link
Copy Markdown
Contributor Author

could we add a new option for this ?

To setup? I could try...

@ej-shafran
Copy link
Copy Markdown
Contributor Author

It's been a while, but I've added it as a configuration option in setup... I'll update it in the docs in a bit

Comment thread lua/guard/init.lua
@xiaoshihou514
Copy link
Copy Markdown
Member

Would you mind documenting the change?

@ej-shafran ej-shafran changed the title Add GuardFmtNoSave command feat: add save_on_fmt setup option Feb 9, 2024
@xiaoshihou514
Copy link
Copy Markdown
Member

Cool, ideally we should probably add a test for this but I guess it's fine for now.

@xiaoshihou514 xiaoshihou514 merged commit 2729748 into nvimdev:main Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants