Skip to content

Conversation

@wakame1367
Copy link
Collaborator

@wakame1367 wakame1367 commented Feb 18, 2020

This PR fixes #42

@nyanp nyanp self-requested a review February 18, 2020 14:22
@nyanp
Copy link
Owner

nyanp commented Feb 18, 2020

Thanks for your series of work!!

Since the original work of StratifiedGroupKFold is distributed under the apache-2.0 license, we must note that you changed the original work (see section 4.b in the license term).

Would you please add the statement that you changed the original work of StratifiedGroupKFold? Maybe this code is helpful as an example of modified work of apache-licensed code.

Copy link
Owner

@nyanp nyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wakamezake LGTM! 🥇 Can I merge it before #40 and #41?

@wakame1367
Copy link
Collaborator Author

OK👍

@nyanp nyanp merged commit 8f1f335 into nyanp:master Feb 19, 2020
@nyanp
Copy link
Owner

nyanp commented Feb 19, 2020

Done. Thanks for your contribution! 💯

@wakame1367 wakame1367 deleted the features/remove_ubelt branch February 19, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency to ubelt

2 participants