add Pocket and Instapaper share buttons and icons #201
Conversation
|
this is the result of running the demos for me, with the two new icons at the end |
src/InstapaperShareButton.js
Outdated
|
|
||
| return 'http://www.instapaper.com/hello2' + objectToGetParams({ | ||
| url, | ||
| text: title, |
There was a problem hiding this comment.
Should the name of the parameter be title?
I did not find the official documentation, but https://feedbin.com/help/sharing-read-it-later-services/ and https://gist.github.com/revelt/a70923df337f7923e067 suggest that url and title would be the parameters to use here.
There was a problem hiding this comment.
I found the documentation and title is correct, plus it allows a description property. I'll add these.
src/PocketShareButton.js
Outdated
|
|
||
| return 'https://getpocket.com/save' + objectToGetParams({ | ||
| url, | ||
| text: title, |
There was a problem hiding this comment.
The same question over here: should the query parameter be named title? The links mentioned in the previous comment provide examples for Pocket. There it seems that title is used.
There was a problem hiding this comment.
Good catch! After reviewing the documentation for their API it looks like the title parameter is ignored if Pocket can get a title parameter from the shared page, so it looked like it was working for me when I tested. I'll make this change, and also I notice that Pocket supports a tags property and also a tweet_id so I'll update to add those.
|
okay @aautio I've updated the code to reflect |
|
It will be awesome when this PR will be merged 🎉 |
aautio
changed the title
…jwrubel-master # Conflicts: # README.md # docs/index.html # docs/main.e2b9c3407372f202448e.bundle.js
3 participants
Hi! I needed these two services for a 'read later' function so I added them. I've checked the demo page and they look ok to me. I used PR #181 as a reference here - Let me know if I missed anything.
Cheers, and thanks for making this awesome library available!