Skip to content

Conversation

@rofrano
Copy link
Contributor

@rofrano rofrano commented Feb 4, 2024

Made the following changes:

  • Converted to app factory pattern as in lab-docker
  • Replaced requirements.txt with Poetry myproject.toml file
  • Updated development environment with latest packages
  • Removed green and replaced with pytest
  • Removed unneeded try/catch blocks from the imported lab-docker code
  • Fixed all linting errors
  • Updated GitHub Action to use new dev tools like Poetry

@codecov
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (de94f2b) 93.54% compared to head (66b0cac) 96.28%.

Files Patch % Lines
service/models.py 95.52% 3 Missing ⚠️
service/__init__.py 90.00% 2 Missing ⚠️
service/common/error_handlers.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   93.54%   96.28%   +2.73%     
==========================================
  Files           7        7              
  Lines         217      242      +25     
==========================================
+ Hits          203      233      +30     
+ Misses         14        9       -5     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rofrano rofrano merged commit 25f624c into master Feb 4, 2024
@rofrano rofrano deleted the spring24-updates branch February 4, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants