Render function Cuda grid refactored from 2D to 1D #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es instead of block.group_index().x and block.group_index().y.
…riable in forward.cu
…riable and block2d_xys array in forward.cu
…iable instead of host_count
…bility in forward.cu
…map in forward.cu
…map in backward.cu
…able instead of dev_count
Collaborator
|
The modification looks good. It speeds things up as expected and the code is clean. We should merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details before change
Loss
python_time_ws=2_rk=0.log
python_time_ws=2_rk=1.log
Gpu time
gpu_time_ws=2_rk=0.log
gpu_time_ws=2_rk=1.log
Details after change
Loss
python_time_ws=2_rk=0.log
python_time_ws=2_rk=1.log
Gpu time
gpu_time_ws=2_rk=0.log
gpu_time_ws=2_rk=1.log
TODO
Use prefix sum and optimize computation of
block_countfromcompute_locally