task(ci): more informative bootstrap test

fixes: #468

Author: akoptelov

.github/workflows/ci.yaml

@@ -124,8 +124,8 @@ jobs:
         run: |
           mkdir -p target/release/tests
 
-          cargo build --release --features=scenario-generators --package=openmina-node-testing --tests
-          cargo build --release --features=scenario-generators --package=openmina-node-testing --tests --message-format=json > cargo-build-test.json
+          cargo build --release --tests --package=openmina-node-testing --package=cli
+          cargo build --release --tests --package=openmina-node-testing --package=cli --message-format=json > cargo-build-test.json
           jq -r '. | select(.executable != null and (.target.kind | (contains(["test"])))) | [.target.name, .executable ] | @tsv' cargo-build-test.json > tests.tsv
           while read NAME FILE; do cp -a $FILE target/release/tests/$NAME; done < tests.tsv
 
@@ -261,63 +261,52 @@ jobs:
 
 
   bootstrap-test:
-    needs: [ k8s-peers, build ]
+    needs: [ k8s-peers, build, build-tests ]
     runs-on: ubuntu-20.04
     env:
-      PEERS: ${{ needs.k8s-peers.outputs.peers }}
+      PEERS_LIST: ${{ needs.k8s-peers.outputs.peers }}
+      PEER_LIST_FILE: peer-list.txt
     steps:
       - name: Download binary
         uses: actions/download-artifact@v4
         with:
           name: bin
 
-      - name: Bootstrap node
+      - name: Download test
+        uses: actions/download-artifact@v4
+        with:
+          pattern: tests*
+          merge-multiple: true
+
+      - name: Fix permissions
         run: |
-          set -eu
-          chmod +x ./openmina
-          ./openmina node --no-peers-discovery --peers $PEERS 2>&1 | tee run.log &
-          PID=$!
-          TIME=10
-          SLEEP=10
-          ATTEMPTS=$((TIME * 60 / SLEEP))
-
-          healthy() {
-            curl -fs -m 5 localhost:3000/healthz
-          }
+          chmod +x bootstrap openmina
 
-          ready() {
-            curl -fs -m 5 localhost:3000/readyz
-          }
+      - name: Peer List File
+        run: |
+          for PEER in $PEERS_LIST; do echo $PEER; done > $PEER_LIST_FILE
+          cat $PEER_LIST_FILE
 
-          ready3() {
-            ready && sleep 10 && ready && sleep 10 && ready
+      - name: Bootstrap node
+        env:
+          OPENMINA_COMMAND: ./openmina
+          NO_PEER_DISCOVERY: "true"
+          WORK_DIR: data
+          OUT_PATH: data/bootstrap_output
+          RECORD: state-with-input-actions
+        run: |
+          mkdir $WORK_DIR
+          OPENMINA_COMMAND=./openmina NO_PEER_DISCOVERY=true ./bootstrap --nocapture || {
+            {
+               echo "::group::Stderr"
+               cat bootstrap_output.stderr
+               echo "::endgroup::"
+            } >>$GITHUB_OUTPUT
           }
 
-          while ! healthy; do
-              echo "::notice::The node is not healthy yet"
-              ATTEMPTS=$((ATTEMPTS-1))
-              if [ "${ATTEMPTS}" -eq 0 ]; then
-                  echo "::error::Cannot bootsrtap within $TIME minutes"
-                  exit 1
-              fi
-              sleep $SLEEP
-          done
-          echo "::notice::The node is healthy"
-
-          while ! ready3; do
-              echo "::notice::The node is not bootstrapped yet"
-              ATTEMPTS=$((ATTEMPTS-1))
-              if [ "${ATTEMPTS}" -eq 0 ]; then
-                  echo "::error::Cannot bootsrtap within $TIME minutes"
-                  exit 1
-              fi
-              sleep $SLEEP
-          done
-          echo "::notice::The node is bootstrapped"
-
       - name: Upload run.log
         uses: actions/upload-artifact@v4
         with:
-          name: bootstrap-log
-          path: run.log
+          name: bootstrap-data
+          path: work/*
         if: ${{ failure() }}

Cargo.lock

@@ -25,6 +25,8 @@ vrf = { workspace = true }
 console = "0.15.5"
 clap = { version = "4.3", features = [ "derive", "env" ] }
 time = { version = "0.3", features = ["formatting", "macros", "parsing"] }
+anyhow = "1.0.81"
+reqwest = "0.11.24"
 
 openmina-core = { path = "../core" }
 node = { path = "../node", features = ["replay"] }
@@ -36,6 +38,9 @@ shellexpand = "3.1.0"
 dialoguer = "0.10.4"
 serde_json = "1.0.107"
 
+[dev-dependencies]
+tempfile = "3.8.0"
+
 [features]
 default = ["p2p-libp2p"]
 unsafe-signal-handlers = []

cli/Cargo.toml

@@ -5,7 +5,7 @@ use node::BuildEnv;
 pub struct Command;
 
 impl Command {
-    pub fn run(&self) -> Result<(), crate::CommandError> {
+    pub fn run(&self) -> anyhow::Result<()> {
         let build_env = BuildEnv::get();
         println!(
             r#"

cli/src/commands/build_info/mod.rs

@@ -2,16 +2,14 @@ use libp2p_identity::PeerId;
 use node::account::AccountSecretKey;
 use node::p2p::identity::SecretKey;
 
-use crate::CommandError;
-
 #[derive(Debug, clap::Args)]
 pub struct Misc {
     #[command(subcommand)]
     command: MiscCommand,
 }
 
 impl Misc {
-    pub fn run(self) -> Result<(), CommandError> {
+    pub fn run(self) -> anyhow::Result<()> {
         match self.command {
             MiscCommand::P2PKeyPair(command) => command.run(),
             MiscCommand::MinaKeyPair(command) => command.run(),
@@ -32,7 +30,7 @@ pub struct P2PKeyPair {
 }
 
 impl P2PKeyPair {
-    pub fn run(self) -> Result<(), CommandError> {
+    pub fn run(self) -> anyhow::Result<()> {
         let secret_key = self.p2p_secret_key.unwrap_or_else(SecretKey::rand);
         let public_key = secret_key.public_key();
         let peer_id = public_key.peer_id();
@@ -53,7 +51,7 @@ pub struct MinaKeyPair {
 }
 
 impl MinaKeyPair {
-    pub fn run(self) -> Result<(), CommandError> {
+    pub fn run(self) -> anyhow::Result<()> {
         let secret_key = self.secret_key.unwrap_or_else(AccountSecretKey::rand);
         let public_key = secret_key.public_key();
         println!("secret key: {secret_key}");

cli/src/commands/misc.rs

@@ -4,8 +4,6 @@ pub mod node;
 pub mod replay;
 pub mod snark;
 
-pub type CommandError = Box<dyn std::error::Error>;
-
 #[derive(Debug, clap::Parser)]
 #[command(name = "openmina", about = "Openmina Cli")]
 pub struct OpenminaCli {
@@ -26,7 +24,7 @@ pub enum Command {
 }
 
 impl Command {
-    pub fn run(self) -> Result<(), crate::CommandError> {
+    pub fn run(self) -> anyhow::Result<()> {
         match self {
             Self::Snark(v) => v.run(),
             Self::Node(v) => v.run(),