Skip to content

Conversation

@Aqil-Ahmad
Copy link
Contributor

@Aqil-Ahmad Aqil-Ahmad commented Oct 19, 2025

What does this PR do?

  • My bugfix
  • Feature: add reusable DataList and refactor list blocks

Related Ticket(s)

Notion: Data tables refactor (issue #305 )

Key Changes
DataList
component in packages/ui/src/components/DataList/
with typed column renderers (text, badge, date, price, link, badgeStatus, custom).
NEW DataList in:
packages/blocks/ticket-list/src/frontend/TicketList.client.tsx
packages/blocks/order-list/src/frontend/OrderList.client.tsx
packages/blocks/invoice-list/src/frontend/InvoiceList.client.tsx
packages/blocks/notification-list/src/frontend/NotificationList.client.tsx

[docs/dev] Storybook stories for DataList:
packages/ui/src/components/DataList/DataList.stories.tsx

How to test

Storybook:

  • npm run storybook
  • Open http://localhost:6006 → Components → DataList
    Verify all stories render (Basic Text, With Badges, With Actions, With Price, Custom Cell Renderer, Empty State, With Custom Styling).

App test:

Login with test users:
Verify list pages render with DataList:

  • Tickets, Orders, Invoices, Notifications

Feedback
The monorepo is well structured with clear separation between /packages and /apps and setup was smooth after npm install. the workspace organization made sense once explored @o2s/ui, for shared components, and @o2s/blocks, for feature modules, but understanding the relationship between framework types and block-level API harmonization took a bit of time. Overall the project is well organized and maintainable. Prettier configuration was quite strict (good for consistency tho).

Media (Loom or gif)

@vercel
Copy link

vercel bot commented Oct 19, 2025

@Aqil-Ahmad is attempting to deploy a commit to the Hycom Team Team on Vercel.

A member of the Team first needs to authorize it.

@Aqil-Ahmad
Copy link
Contributor Author

/claim #305

@opirebot
Copy link

opirebot bot commented Oct 19, 2025

👀 We've notified the reward creators here.
Make sure your payment account is ready to receive the payment for your hard work 💪

@marcinkrasowski marcinkrasowski self-requested a review October 20, 2025 06:13
@marcinkrasowski
Copy link
Collaborator

marcinkrasowski commented Oct 20, 2025

@Aqil-Ahmad please run linter and fix the errors, it reports multiple issues both in the ui package as well as in frontend related to incorrect types and some other errors.
Please especially check the frontend app - currently it doesn't even start due to these issues so I'm unable to test if it works.

@marcinkrasowski
Copy link
Collaborator

marcinkrasowski commented Oct 20, 2025

@Aqil-Ahmad also, please provide a short feedback as per ticket description, either in a comment or better yet in the PR description:
As an additional requirement, please provide a short feedback on your experiences with working with this framework - how easy or difficult it was to get started (including starting the project, getting around the monorepo or readings our docs) and to make the required changes.

@Aqil-Ahmad
Copy link
Contributor Author

currently it doesn't even start due to these issues so I'm unable to test if it works.

Thanks for the feedback! I'll fix all linting and type errors in ui and frontend. The app starts fine (login page appears), but I need to set up authentication to test the actual list components. I'll investigate the seed scripts or test user setup.
Pushing fixes shortly.

@marcinkrasowski
Copy link
Collaborator

@Aqil-Ahmad Ok, so the frontend app itself runs fine when you start it directly (npm run dev inside ./apps/frontend) but if you try running the whole project (npm run dev inside ./) it doesn't actually start, due to errors in dependent packages:
image

As for authentication, it should be already pre-configured (we have a simple sqlite database set up with prisma), you can find the credentials in our docs

@Aqil-Ahmad Aqil-Ahmad force-pushed the feat/add-datalist-component branch from 3347ed4 to fd2161c Compare October 21, 2025 13:02
@marcinkrasowski
Copy link
Collaborator

@Aqil-Ahmad looks better, but please check my comments as I think this component can still be improved

@Aqil-Ahmad Aqil-Ahmad force-pushed the feat/add-datalist-component branch from fd2161c to 5b1539c Compare October 24, 2025 15:12
@Aqil-Ahmad
Copy link
Contributor Author

@Aqil-Ahmad looks better, but please check my comments as I think this component can still be improved

thanks for the review! i've made the updates. let me know if there's anything else you'd like me to adjust

Copy link
Collaborator

@marcinkrasowski marcinkrasowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aqil-Ahmad looks almost ready, please check my replies to earlier comments for a few more changes and I think we will be ready to merge it (and submit reward of course)

@Aqil-Ahmad Aqil-Ahmad force-pushed the feat/add-datalist-component branch from 5b1539c to 8c5def0 Compare October 27, 2025 15:13
@marcinkrasowski
Copy link
Collaborator

@Aqil-Ahmad looks good, we'll merge it once the reward is issued, hopefully in a couple of days

@marcinkrasowski marcinkrasowski merged commit cbd96e6 into o2sdev:main Oct 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants