Skip to content

Conversation

@yoichi
Copy link
Contributor

@yoichi yoichi commented Oct 15, 2020

Enable image backends on macOS because we have terminals with graphics support on macOS.

mlterm supports sixel:
スクリーンショット 2020-10-15 19 14 52

kitty:
スクリーンショット 2020-10-15 19 12 55

NOTE: iTerm2 also supports sixel but it shows broken output (I think it is a iTerm2 issue):
スクリーンショット 2020-10-15 19 19 25

@o2sh
Copy link
Owner

o2sh commented Oct 15, 2020

Enable image backends on macOS because we have terminals with graphics support on macOS.

Great! I don't have a machine running macOS so I couldn't test it for myself.

Your PR looks good. What would you think about replacing #[cfg(not(target_os = "windows"))] with #[cfg(not(windows))] ?

iTerm2 also supports sixel but it shows broken output

Yes, that's weird. Have you tried onefetch -i /path/to/image --image-backend sixel

@yoichi
Copy link
Contributor Author

yoichi commented Oct 15, 2020

Your PR looks good. What would you think about replacing #[cfg(not(target_os = "windows"))] with #[cfg(not(windows))] ?

Applied in 0cf7398.

iTerm2 also supports sixel but it shows broken output

Yes, that's weird. Have you tried onefetch -i /path/to/image --image-backend sixel

I've already tried. It is not a problem of image backend selection.

@yoichi yoichi force-pushed the enable-image-backend-on-macos branch from b299d5f to fdffb65 Compare October 15, 2020 22:03
@o2sh o2sh merged commit 792850e into o2sh:master Oct 15, 2020
@yoichi
Copy link
Contributor Author

yoichi commented Oct 21, 2020

FYI: I've reported a issue on iTerm2 https://gitlab.com/gnachman/iterm2/-/issues/9204, which causes the broken output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants