Clean up TX filtering and listing code #2082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/tx-list-code-cleanup
branch
from
9ccbc07 to
3bf8f34
Compare
csillag
force-pushed
the
csillag/tx-list-code-cleanup
branch
5 times, most recently
from
cd435fb to
e8e47ef
Compare
lukaw3d
approved these changes
Jul 28, 2025
lukaw3d
reviewed
Jul 28, 2025
csillag
force-pushed
the
csillag/tx-list-code-cleanup
branch
from
e8e47ef to
8fc7a7d
Compare
Since we are actually filtering for TX method here, not type.
Also, finish inconsistent renaming of "setMethod" props to "setTxMethod", to better distinguish between props referring to transactions and events.
Since we are actually filtering for TX method here, not type.
csillag
force-pushed
the
csillag/tx-list-code-cleanup
branch
from
931312f to
a3e6bff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I am applying new insights gained during implementing event type filtering
to the previously implemented transaction method filtering: