AddressLink formatting fixes #2107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/address-formatting-fixes
branch
2 times, most recently
from
7e9fd31 to
4f55839
Compare
lukaw3d
reviewed
Jul 30, 2025
Comment on lines
171
to
176
| <Box | ||
| component="span" | ||
| sx={{ display: 'inline-flex', alignItems: 'center', gap: 3, flexWrap: 'wrap' }} | ||
| > | ||
| <AccountMetadataSourceIndicator source={accountMetadata!.source} /> | ||
| <HighlightedText text={accountName} pattern={highlightPattern} /> ({address}) |
Member
Contributor
Author
There was a problem hiding this comment.
Short version: #2072 didn't create the error, just exposed it by triggering it accidentally. Now I fix both the original problem and the accidental trigger.
Here is the full history.
- There was a error in
AdaptivelyTrimmedAccountLink: under specific conditions (if there is sufficient width to show both account name and address at the same line), it rendered ugly content. - However, this error was not triggered very often, because
AdaptivelyTrimmedAccountLinkwas only used when we were short on space. - However, in Further enhance ROFL app endorsement display #2072, when introducing an option for always enabling the adaptive trimmer in
AccountLink(even if we are on desktop and have lots of space), I have introduced an error by checking the wrong variable in a condition. (I meant to check the new option,alwaysAdapt, but I accidentally wrotealwaysTrimOnTablet.) This resulted in accidentally usingAdaptivelyTrimmedAccountLinkin unintended situations, including situations with lots of available width, therefore triggering this pre-existing, but previously hidden error. - This PR fixes the condition (for selecting the right kind of link), plus it improves both
AdaptivelyTrimmedAccountLinkandDesktopAccountLinkto better handle wrapping / non-wrapping situations, thereby eliminating the original error.
Contributor
Author
There was a problem hiding this comment.
so I'm concerned something else will break.
That's not an unreasonable assumption; that is why I did manual testing by slowly changing the width and checking the behavior on multiple pages. I don't see anything broken.
csillag
force-pushed
the
csillag/address-formatting-fixes
branch
2 times, most recently
from
dde4d93 to
ffaebb2
Compare
- If we show both account name and address, put the addressin parenthesis. - Properly align name and address side by side - More consistent wrapping and gap setting
- Fix reference to wrong variable name, which messed up the table/desktop selection in some situations
csillag
force-pushed
the
csillag/address-formatting-fixes
branch
from
ffaebb2 to
833be73
Compare
lukaw3d
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small adjustments in AddressLink CSS.
Improves #2096.