Replace MUI tabs with Oasis UI Library component #2122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
changed the title
buberdds
force-pushed
the
mz/uil-tabs
branch
8 times, most recently
from
bfb22fe to
9ed631c
Compare
lukaw3d
approved these changes
Aug 20, 2025
| to={tab.to} | ||
| /> | ||
| ))} | ||
| <Tabs value={targetTab?.to}> |
Member
There was a problem hiding this comment.
Future issue / UX regression: on mobile if there's not enough space https://explorer.dev.oasis.io/mainnet/sapphire/address/0x65524539A0Db2dB286b3a05E4E191eA810295CE2
https://pr-2122.oasis-explorer.pages.dev/mainnet/sapphire/address/0x65524539A0Db2dB286b3a05E4E191eA810295CE2
Before: touch-scrollable
After: "Transactions" are offscreen on left, "Code" is offscreen on right
Contributor
Author
There was a problem hiding this comment.
that needs to be fixed before merging
lukaw3d
reviewed
Aug 21, 2025
buberdds
force-pushed
the
mz/uil-tabs
branch
from
d387fc9 to
e64b921
Compare
buberdds
force-pushed
the
mz/uil-tabs
branch
from
e64b921 to
dddbc8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waits for oasisprotocol/ui-library#49,oasisprotocol/ui-library#57Used in:
Consensus acc staked/debonding
https://pr-2122.oasis-explorer.pages.dev/mainnet/consensus/address/oasis1qr3dyzj5aed7f2zq6rrrpzklzfl37t0tsvvffa9m
vs
https://explorer.oasis.io/mainnet/consensus/address/oasis1qr3dyzj5aed7f2zq6rrrpzklzfl37t0tsvvffa9m
Card filters
https://pr-2122.oasis-explorer.pages.dev/mainnet/sapphire/token
vs
https://explorer.oasis.io/mainnet/sapphire/token
https://pr-2122.oasis-explorer.pages.dev/mainnet/consensus/proposal/5
vs
https://explorer.oasis.io/mainnet/consensus/proposal/5
Duration selection in cards with charts
https://pr-2122.oasis-explorer.pages.dev/mainnet/consensus
vs
https://explorer.oasis.io/mainnet/consensus
Router tabs (most of details pages)
https://pr-2122.oasis-explorer.pages.dev/mainnet/sapphire/token/0x39d22B78A7651A76Ffbde2aaAB5FD92666Aca520
vs
https://explorer.oasis.io/mainnet/sapphire/token/0x39d22B78A7651A76Ffbde2aaAB5FD92666Aca520