Simplify pattern highlight implementation #2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/simplify-highlight-implementation
branch
2 times, most recently
from
d9f4810 to
caccd38
Compare
csillag
changed the title
csillag
force-pushed
the
csillag/simplify-highlight-implementation
branch
3 times, most recently
from
1ab2ff8 to
8949ebd
Compare
csillag
force-pushed
the
csillag/simplify-highlight-implementation
branch
from
8949ebd to
457e774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the when we were highlighting text based on search text or similar, we were passing down the information about what to highlight along the component tree.
This change moves this information into a React Context, so that components that are not involved with the highlighting process (i.e. they are neither the source nor the actual consumers of this information) don't have to deal with passing along this information.
This makes a code simpler.
I suggest reviewing commit by commit.