Skip to content

Conversation

@kaja-osojnik
Copy link
Collaborator

@kaja-osojnik kaja-osojnik commented Sep 29, 2025

Added word wrapping for events code snippets on mobile.

Fixes: #2181

Before:
Screenshot 2025-09-29 at 13 56 27

After:
pr-2216 oasis-explorer pages dev_mainnet_consensus_block_26621356_events(iPhone SE)

@github-actions
Copy link

github-actions bot commented Sep 29, 2025

Deployed to Cloudflare Pages

Latest commit: 3d16b1bc79c9ba79a617b258dd7e604abbe5aae8
Status:✅ Deploy successful!
Preview URL: https://724b06ee.oasis-explorer.pages.dev
Alias: https://pr-2216.oasis-explorer.pages.dev

@lukaw3d
Copy link
Member

lukaw3d commented Sep 29, 2025

I think we usually wrap text to new line, not add horizontal scroll. Are we switching to more horizontal scrolls, or just here?

@kaja-osojnik
Copy link
Collaborator Author

I think we usually wrap text to new line, not add horizontal scroll. Are we switching to more horizontal scrolls, or just here?

@donouwens ?

@donouwens
Copy link
Contributor

donouwens commented Oct 1, 2025

I think we usually wrap text to new line, not add horizontal scroll. Are we switching to more horizontal scrolls, or just here?

@donouwens ?

For code snippets I think wrapping works great. 👍🏻

@donouwens @lukaw3d - updated.

@kaja-osojnik kaja-osojnik force-pushed the kaja/events-code-snippet-scroll branch 2 times, most recently from 0f35f7d to 355ffe2 Compare October 2, 2025 12:55
@lukaw3d
Copy link
Member

lukaw3d commented Oct 2, 2025

Updated screenshot
pr-2216 oasis-explorer pages dev_mainnet_consensus_block_26621356_events(iPhone SE)

@kaja-osojnik kaja-osojnik changed the title Code snippet overflow scroll Code snippet wrapping on mobile Oct 3, 2025
@kaja-osojnik kaja-osojnik force-pushed the kaja/events-code-snippet-scroll branch from 355ffe2 to c2e3c61 Compare October 3, 2025 12:26
@kaja-osojnik kaja-osojnik requested a review from lukaw3d October 7, 2025 13:07
@lukaw3d lukaw3d force-pushed the kaja/events-code-snippet-scroll branch from c2e3c61 to 3d16b1b Compare October 8, 2025 11:17
@lukaw3d lukaw3d enabled auto-merge October 8, 2025 11:17
@lukaw3d lukaw3d merged commit f1d58ed into master Oct 8, 2025
9 checks passed
@lukaw3d lukaw3d deleted the kaja/events-code-snippet-scroll branch October 8, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Horizontal scroll is missing on mobile on Events tab

4 participants