Replace MUI Tooltip with Oasis UI Library component #2299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
force-pushed
the
mz/uil-tooltip-2
branch
from
7c3b338 to
ec3bf11
Compare
buberdds
force-pushed
the
mz/uil-tooltip-2
branch
3 times, most recently
from
b8252ce to
2df7860
Compare
kaja-osojnik
approved these changes
Nov 3, 2025
lukaw3d
approved these changes
Nov 4, 2025
buberdds
force-pushed
the
mz/uil-tooltip-2
branch
from
2df7860 to
1ff6aa5
Compare
lukaw3d
reviewed
Nov 8, 2025
Comment on lines
18
to
22
| return ( | ||
| <div className="flex items-center gap-2"> | ||
| <Tooltip | ||
| placement="top" | ||
| arrow | ||
| slotProps={{ tooltip: { sx: { fontWeight: 'normal' } } }} | ||
| title={ | ||
| metadata?.origin && ( |
Member
There was a problem hiding this comment.
In MUI this didn't show a tooltip if origin was missing:
https://explorer.dev.oasis.io/mainnet/sapphire/address/0x3cAbbe76Ea8B4e7a2c0a69812CBe671800379eC8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate tooltips with more complex content
Needs oasisprotocol/ui-library#82
Token row -> token icon with name / token origin
https://pr-2299.oasis-explorer.pages.dev/mainnet/sapphire/token/0x39d22B78A7651A76Ffbde2aaAB5FD92666Aca520
vs https://explorer.dev.oasis.io/mainnet/sapphire/token/0x39d22B78A7651A76Ffbde2aaAB5FD92666Aca520
Metadata -> Repository URL help icon
https://pr-2299.oasis-explorer.pages.dev/mainnet/sapphire/rofl/app/rofl1qpdzzm4h73gtes04xjn4whan84s3k33l5gx787l2
vs https://explorer.dev.oasis.io/mainnet/sapphire/rofl/app/rofl1qpdzzm4h73gtes04xjn4whan84s3k33l5gx787l2
Age column content
https://pr-2299.oasis-explorer.pages.dev/mainnet/consensus
vs https://explorer.dev.oasis.io/mainnet/consensus
regular tooltip (string content) but covered by tests
https://pr-2299.oasis-explorer.pages.dev/mainnet/consensus/address/oasis1qpg2xuz46g53737343r20yxeddhlvc2ldqsjh70p
vs https://explorer.dev.oasis.io/mainnet/consensus/address/oasis1qpg2xuz46g53737343r20yxeddhlvc2ldqsjh70p