Remove usage of MUI useMediaQuery #2347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
Closed
buberdds
force-pushed
the
mz/mui-useMediaQuery
branch
from
cbea36f to
6fe950d
Compare
lukaw3d
approved these changes
Nov 14, 2025
src/app/hooks/useScreensize.ts
Outdated
Comment on lines
19
to
33
| const handleResize = () => { | ||
| const isMobile = window.matchMedia(`(max-width: ${BREAKPOINTS.md - 1}px)`).matches | ||
| const isTablet = window.matchMedia(`(max-width: ${BREAKPOINTS.lg - 1}px)`).matches | ||
| const isLaptop = window.matchMedia(`(max-width: ${BREAKPOINTS.xl - 1}px)`).matches | ||
| const isDesktop = window.matchMedia(`(min-width: ${BREAKPOINTS.xl}px)`).matches | ||
|
|
||
| setScreenSize({ | ||
| isMobile, | ||
| isTablet, | ||
| isLaptop, | ||
| isDesktop, | ||
| }) | ||
| } | ||
|
|
||
| window.addEventListener('resize', handleResize) |
Member
There was a problem hiding this comment.
Previous mui implementation used mediaQueryList.addEventListener('change', notify);
https://github.com/mui/material-ui/blob/dba602459c8b50d34ecbf3c6e61a3f805c7cb413/packages/mui-system/src/useMediaQuery/useMediaQuery.ts#L103-L108
to consider if we see any issues
Contributor
Author
There was a problem hiding this comment.
switched to media query change listener
buberdds
force-pushed
the
mz/mui-useMediaQuery
branch
2 times, most recently
from
c8f8f06 to
23cd93e
Compare
buberdds
force-pushed
the
mz/mui-useMediaQuery
branch
from
23cd93e to
59a79c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.