Improve/fix styling of search results on mobile#524
Conversation
Deployed to Cloudflare Pages
|
|
The basics are correct @csillag (as you asked). There is a small thing;
Moreover, the search, paratime selector, and eco system aren't working for me here. I copied the string for multiple results but it still only shows my 1 results on mainnet and one (hidden) on testnet (/search?q=123). So I couldn't check the multiple results yet. 
|
The problem is that we have now disabled emerald both on mainnet and testnet, so you won't have multiple results within mainnet. However, if I enable it for you in my dev build, then it shows:
|
Would this be all right?
|
csillag
force-pushed
the
csillag/fix-mobile-search
branch
4 times, most recently
from
3189ea8 to
bfedfda
Compare
| isMobile | ||
| ? { | ||
| border: | ||
| theme.palette.background.default !== theme.palette.layout.border |
There was a problem hiding this comment.
This comparison is to target specific theme? I wonder if it's not safer to define custom border in each theme and just theme.layout.myMagicBorder.
There was a problem hiding this comment.
No, because when we don't want the see border, then we don't want to have it at all; when it's there, it's really thick, and so it's a big waste of space to have an invisible border. Plus there are other changes, including the different border radius...
csillag
force-pushed
the
csillag/fix-mobile-search
branch
from
bfedfda to
d2b4969
Compare
3 participants
Task:
So the mobile visuals were gone and I recreated them here. They should follow the desktop logic, these visuals serve the purpose of UI more than functionality - so if you come across inconsistencies please follow what’s on desktop. Let me know if you got questions.
Wanted visual:
Solution:
Global search
Search launched from TestNet
|