Differentiate user being offline and API being offline#579
Conversation
Deployed to Cloudflare Pages
|
| }, | ||
| "home": { | ||
| "apiOffline": "Our {{ target }} API is offline. We’re trying to reconnect", | ||
| "userOffline": "You are offline. We’re trying to reconnect", |
| import { paraTimesConfig } from '../../../config' | ||
|
|
||
| export const useIsApiOffline = (network: Network): boolean => { | ||
| export const useIsApiOffline = (network: Network): false | 'userOffline' | 'apiOffline' => { |
There was a problem hiding this comment.
At this point I think we should rename this to useNetworkProblem().
There was a problem hiding this comment.
I think that's too confusing: user's "network" && mainnet "network"?
There was a problem hiding this comment.
isApiReachable?
No, that would make the "false" return value confusing.
How about useConnectionProblem() ?
There was a problem hiding this comment.
but it's not necessarily a connection problem if API is unresponsive :D
There was a problem hiding this comment.
OK, I am fine with useIsApiReachable, but then we need a different result structure. { reachable: true } when all is fine, and { reachable: false, reason: "whatever" } in case of issues.
csillag
left a comment
csillag
left a comment
There was a problem hiding this comment.
Reviewed, LGTM. (See comment)
| <StyledAlert severity="warning">{t('home.apiOffline', { target })}</StyledAlert> | ||
| ) : null | ||
| if (!isNetworkReachable.reachable) { | ||
| if (isNetworkReachable.reason === 'userOffline') { |
There was a problem hiding this comment.
I would prefer adding the full text of reason right inside the hook (we have access to translation there, too); no need to have a layer of compilation here...
| <SearchInputContainer> | ||
| <SearchInputBox> | ||
| <Search disabled={isApiOffline} variant={searchVariant} onFocusChange={onFocusChange} /> | ||
| <Search disabled={!isApiReachable} variant={searchVariant} onFocusChange={onFocusChange} /> |
There was a problem hiding this comment.
I think we need to update this to get the inside from within the structure returned by the hook.
2 participants
No description provided.