Show block-level events in block details #990
Merged
Merged
Conversation
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/block-level-events
branch
from
dbe10db to
c4b2960
Compare
csillag
changed the title
csillag
force-pushed
the
csillag/block-level-events
branch
from
c4b2960 to
881a9c6
Compare
csillag
force-pushed
the
csillag/block-level-events
branch
5 times, most recently
from
cde7268 to
caba9e7
Compare
csillag
force-pushed
the
csillag/block-level-events
branch
2 times, most recently
from
6c173a2 to
34fb4fb
Compare
Contributor
Author
|
We decided to do the tweaking of the event filter in a separate PR. |
Contributor
Author
lukaw3d
reviewed
Nov 7, 2023
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-redeclare | ||
| export type EventFilterMode = (typeof EventFilterMode)[keyof typeof EventFilterMode] |
Contributor
There was a problem hiding this comment.
How does this + export const EventFilterMode = { work
Contributor
Author
There was a problem hiding this comment.
On is a type, the other is a const. TS compiler is smart enough to figure out which one we want in each situation. (The type is actually eliminated during the transpilation phase, so in the JS we only have the const.)
In any case, this is not something I came up with here, we already have a similar solution for Layer and other things, too.
lukaw3d
reviewed
Nov 7, 2023
csillag
force-pushed
the
csillag/block-level-events
branch
from
34fb4fb to
3126e3e
Compare
lukaw3d
approved these changes
Nov 7, 2023
W.I.P. because filtering out tx-level events is done on the client
csillag
force-pushed
the
csillag/block-level-events
branch
from
2398743 to
51e2e75
Compare
csillag
force-pushed
the
csillag/block-level-events
branch
from
51e2e75 to
b8c35b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #991 for some refactoring.Requires (and includes) #893 in order to avoid crashing on new event types.Design is here.
Can we tested with this path:
/testnet/sapphire/block/3038913