Update react-router to v6#1001
Conversation
|
react-router always breaking everything 🤦 I agree with removing animations. If we do keep them though, I'd rather see <Route
element={<FadeIn><HomePage /></FadeIn>}
path="/"
/>than |
I would also rather (temporarily) remove animations. I would just file a GitHub issue to consider re-enabling/re-adding animations once react-router supports them natively. |
4655968 to
ba9ff03
Compare
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
- Coverage 88.77% 88.66% -0.11%
==========================================
Files 101 100 -1
Lines 1764 1747 -17
Branches 407 405 -2
==========================================
- Hits 1566 1549 -17
Misses 198 198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Commit with |
ba9ff03 to
6e68989
Compare
I did not find a way to use
react-transition-groupwith router v6. There were issues with nested routes animations, app re-renders and console warnings. In order to use new router I am switching toframer-motion, but my preference would be not to use any animation lib for routes to keep things simple and wait for official v6 API to support routes animations.