Skip to content

Fix ethereumjs imports#1111

Merged
buberdds merged 1 commit intomasterfrom
buberdds/ethereumjs
Oct 27, 2022
Merged

Fix ethereumjs imports#1111
buberdds merged 1 commit intomasterfrom
buberdds/ethereumjs

Conversation

@buberdds
Copy link
Copy Markdown
Contributor

No description provided.

@buberdds buberdds force-pushed the buberdds/ethereumjs branch from 9e46fa8 to ce7cd3f Compare October 26, 2022 17:05
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 26, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.01s
✅ JSON eslint-plugin-jsonc 1 0 0 1.17s
✅ JSON jsonlint 1 0 2.63s
✅ JSON prettier 1 0 0 0.52s
✅ JSON v8r 1 0 6.38s
✅ REPOSITORY checkov yes no 14.59s
✅ REPOSITORY git_diff yes no 0.06s
✅ TYPESCRIPT eslint 1 0 0 4.94s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@buberdds buberdds requested a review from lukaw3d October 26, 2022 17:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 26, 2022

Codecov Report

Merging #1111 (9e46fa8) into master (ea5c74c) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 9e46fa8 differs from pull request most recent head ce7cd3f. Consider uploading reports for the commit ce7cd3f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1111      +/-   ##
==========================================
- Coverage   83.77%   83.68%   -0.09%     
==========================================
  Files         121      121              
  Lines        2249     2249              
  Branches      539      539              
==========================================
- Hits         1884     1882       -2     
- Misses        365      367       +2     
Flag Coverage Δ
cypress 51.80% <ø> (ø)
jest 76.88% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/lib/eth-helpers.ts 30.76% <ø> (ø)
src/app/state/transaction/index.ts 82.85% <0.00%> (-11.43%) ⬇️
src/app/state/transaction/saga.ts 68.08% <0.00%> (-0.71%) ⬇️
src/app/state/account/saga.ts 88.67% <0.00%> (+5.66%) ⬆️

@buberdds buberdds merged commit 6273791 into master Oct 27, 2022
@buberdds buberdds deleted the buberdds/ethereumjs branch October 27, 2022 07:09
@buberdds
Copy link
Copy Markdown
Contributor Author

This package is not working in new extension. If I won't find workaround I will revert this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants