Skip to content

Validate mnemonic words in MnemonicGrid#1180

Merged
lukaw3d merged 2 commits intomasterfrom
lw/validate-mnemonic-words
Nov 29, 2022
Merged

Validate mnemonic words in MnemonicGrid#1180
lukaw3d merged 2 commits intomasterfrom
lw/validate-mnemonic-words

Conversation

@lukaw3d
Copy link
Copy Markdown
Contributor

@lukaw3d lukaw3d commented Nov 29, 2022

Quick improvement since #1181 disables spell-checking mnemonic

Before 1181 After 1181 + this
localhost_3000_open-wallet_mnemonic (1) localhost_3000_open-wallet_mnemonic

@lukaw3d lukaw3d requested review from buberdds and csillag November 29, 2022 04:21
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 29, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 4 0 0.01s
✅ REPOSITORY checkov yes no 12.23s
✅ REPOSITORY git_diff yes no 0.0s
✅ TSX eslint 2 0 0 3.66s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Copy Markdown
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good, this might help people who used a wrong word that's coincidentally a real word

did we support importing mnemonics from other languages? if so, those users will have to ignore this

@lukaw3d
Copy link
Copy Markdown
Contributor Author

lukaw3d commented Nov 29, 2022

🎉 we didn't support other languages; and bip39 now discourages them https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki#wordlists

Fun fact: Japanese mnemonics don't use a normal space, so even our word splitting wouldn't work
image

@lukaw3d lukaw3d force-pushed the lw/validate-mnemonic-words branch from e78a963 to 8092d0e Compare November 29, 2022 19:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 29, 2022

Codecov Report

Merging #1180 (8092d0e) into master (cf54100) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
- Coverage   81.05%   81.04%   -0.01%     
==========================================
  Files         140      140              
  Lines        2639     2638       -1     
  Branches      648      646       -2     
==========================================
- Hits         2139     2138       -1     
  Misses        500      500              
Flag Coverage Δ
cypress 51.50% <100.00%> (-0.02%) ⬇️
jest 74.24% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/MnemonicGrid/index.tsx 100.00% <100.00%> (ø)

@lukaw3d lukaw3d merged commit 91cfce2 into master Nov 29, 2022
@lukaw3d lukaw3d deleted the lw/validate-mnemonic-words branch November 29, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants