Validate mnemonic words in MnemonicGrid#1180
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
pro-wh
left a comment
There was a problem hiding this comment.
oh good, this might help people who used a wrong word that's coincidentally a real word
did we support importing mnemonics from other languages? if so, those users will have to ignore this
|
🎉 we didn't support other languages; and bip39 now discourages them https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki#wordlists Fun fact: Japanese mnemonics don't use a normal space, so even our word splitting wouldn't work |
e78a963 to
8092d0e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
- Coverage 81.05% 81.04% -0.01%
==========================================
Files 140 140
Lines 2639 2638 -1
Branches 648 646 -2
==========================================
- Hits 2139 2138 -1
Misses 500 500
Flags with carried forward coverage won't be shown. Click here to find out more.
|

Quick improvement since #1181 disables spell-checking mnemonic