Conversation
Deployed to Cloudflare Pages
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1792 +/- ##
==========================================
- Coverage 81.44% 81.36% -0.08%
==========================================
Files 191 191
Lines 5067 5067
Branches 930 930
==========================================
- Hits 4127 4123 -4
- Misses 940 944 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
buberdds
approved these changes
Dec 6, 2023
| ws://localhost:2222 | ||
| ` | ||
| const reactErrorOverlay = `'sha256-RV6I4HWPb71LvA27WVD3cEz8GsJrHlfcM/2X2Q5gV00='` | ||
| const reactErrorOverlay = `'sha256-yt+SNVxRkIi6H6yb7ndFuZM1esMX9esg3UpRHaTsyVk='` |
Contributor
There was a problem hiding this comment.
Can you add a comment where we can find this ID so everyone is aware of it and also when it changes?
Contributor
Author
There was a problem hiding this comment.
Related: #1609 (comment)
I copy it from chrome console, it's printed on any hot-module-reload when it's broken.
Modified the test so it would now print:
1) [chromium] › csp-react-error-overlay.spec.ts:5:5 › Dev Content-Security-Policy should allow react-error-overlay
Error: expect(received).not.toMatchObject(expected)
Expected: not {"type": "error"}
Received: {"args": [], "location": {"columnNumber": 0, "lineNumber": 2769, "url": "http://localhost:3000/index.2b04b272.js"}, "text": "Refused to execute inline script because it violates the following Content Security Policy directive: \"script-src 'self' 'sha256-RV6I4HWPb71LvA27WVD3cEz8GsJrHlfcM/2X2Q5gV00=' 'unsafe-eval' 'report-sample'\". Either the 'unsafe-inline' keyword, a hash ('sha256-yt+SNVxRkIi6H6yb7ndFuZM1esMX9esg3UpRHaTsyVk='), or a nonce ('nonce-...') is required to enable inline execution.
", "type": "error"}
at ../utils/expectNoErrorsInConsole.ts:37
35 | text: message.text(),
36 | type: message.type(),
> 37 | }).not.toMatchObject({
| ^
38 | type: 'error',
39 | })
40 | }it's hard to make a prettier output
added 2 commits
December 7, 2023 05:58
7547175 to
e695fea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken since 9c7da1a
Note: react-error-overlay only appears during development, and csp-react-error-overlay.spec.ts doesn't test it on CI. Running it locally detects it as broken tho.