Only show Delegations and Debonding tabs in Stake view#1985
Merged
Conversation
Deployed to Cloudflare Pages
|
This was referenced Jul 2, 2024
buberdds
approved these changes
Jul 3, 2024
| </a> | ||
| <a | ||
| class="c2" | ||
| href="/account/undefined/active-delegations" |
Contributor
There was a problem hiding this comment.
Can we add data-testid to elements that were root previously in all views that now use StakeSubnav?
In tests we could switch from (component.baseElement).toMatchSnapshot() to expect(screen.getByTestId('WHATEVER')).toMatchSnapshot(). I just don't see a value in extra 1k lines of duplicated snapshots here.
lukaw3d
force-pushed
the
lw/staking-subnav
branch
from
0fb642e to
41b9b82
Compare
lukaw3d
force-pushed
the
lw/staking-subnav
branch
from
41b9b82 to
c714913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1946
Fixes part of #276