Fix losing mnemonic input when changing phone orientation#2008
Merged
Fix losing mnemonic input when changing phone orientation#2008
Conversation
Deployed to Cloudflare Pages
|
lukaw3d
force-pushed
the
lw/dont-clear-mnemonic
branch
from
2cebd0f to
abc1c6d
Compare
buberdds
approved these changes
Jul 16, 2024
Contributor
|
I am not able to repro this bug. Is this related to Android app ? |
Contributor
Author
|
Not related to android. E.g. on https://wallet.dev.oasis.io/create-wallet mnemonic-clearing.webm |
A Layer inside Layer seems to lose useState inside MnemonicValidation.
lukaw3d
force-pushed
the
lw/dont-clear-mnemonic
branch
from
abc1c6d to
d3f7432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1714