Refactor dispatching transactions so "Reclaim all" doesn't lose more precision#932
Merged
Refactor dispatching transactions so "Reclaim all" doesn't lose more precision#932
Conversation
lukaw3d
commented
Jul 13, 2022
Comment on lines
+63
to
+64
| amount: props.maxAmount, | ||
| shares: props.shares, |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
lukaw3d
force-pushed
the
lw/precise-reclaim
branch
from
b93a1a6 to
ea1fb6e
Compare
Contributor
Author
|
Oh, we lose precision when parsing from API.. |
Contributor
Author
|
Will revisit in another year. |
lukaw3d
changed the title
lukaw3d
force-pushed
the
lw/precise-reclaim
branch
from
ea1fb6e to
e65f95a
Compare
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
==========================================
- Coverage 88.32% 88.31% -0.01%
==========================================
Files 97 97
Lines 1679 1678 -1
Branches 387 387
==========================================
- Hits 1483 1482 -1
Misses 196 196
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
force-pushed
the
lw/precise-reclaim
branch
from
e65f95a to
422b4f4
Compare
lukaw3d
force-pushed
the
lw/precise-reclaim
branch
from
422b4f4 to
2eb4203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.