Skip to content

Change UI to be more similar to current extension: footer#933

Merged
buberdds merged 1 commit intomasterfrom
buberdds/mobileFooter
Jul 15, 2022
Merged

Change UI to be more similar to current extension: footer#933
buberdds merged 1 commit intomasterfrom
buberdds/mobileFooter

Conversation

@buberdds
Copy link
Copy Markdown
Contributor

  • add fixed menu to footer
  • tweak footer css for mobile

Screenshot 2022-07-14 at 15 17 07
Screenshot 2022-07-14 at 15 17 13

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 14, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 5 0 0.01s
✅ GIT git_diff yes no 0.01s
✅ TSX eslint 4 0 0 6.71s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@buberdds buberdds force-pushed the buberdds/mobileFooter branch from 7b1c5cf to f4e9c99 Compare July 14, 2022 13:28
@buberdds buberdds requested a review from lukaw3d July 14, 2022 13:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 14, 2022

Codecov Report

Merging #933 (6b1b0d7) into master (a62273b) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
+ Coverage   87.59%   87.74%   +0.15%     
==========================================
  Files          97       98       +1     
  Lines        1620     1640      +20     
  Branches      353      358       +5     
==========================================
+ Hits         1419     1439      +20     
  Misses        201      201              
Flag Coverage Δ
cypress 58.06% <76.19%> (+0.21%) ⬆️
jest 74.52% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Footer/index.tsx 100.00% <100.00%> (ø)
...rc/app/components/MobileFooterNavigation/index.tsx 100.00% <100.00%> (ø)

Copy link
Copy Markdown
Contributor

@lukaw3d lukaw3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread src/app/components/Footer/index.tsx Outdated
Comment thread src/app/components/Footer/index.tsx
Comment thread src/app/components/Footer/__tests__/index.test.tsx Outdated
Comment thread src/app/components/Footer/index.tsx Outdated
Comment thread src/app/components/MobileFooterNavigation/index.tsx Outdated
Comment thread src/app/components/MobileFooterNavigation/index.tsx Outdated
Comment thread src/app/components/MobileFooterNavigation/__tests__/index.test.tsx Outdated
@buberdds buberdds force-pushed the buberdds/mobileFooter branch from f4e9c99 to 6b1b0d7 Compare July 15, 2022 09:01
@buberdds buberdds merged commit fe1790a into master Jul 15, 2022
@buberdds buberdds deleted the buberdds/mobileFooter branch July 15, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants