Conversation
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
buberdds
force-pushed
the
buberdds/multi
branch
2 times, most recently
from
23d7238 to
caa05cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
+ Coverage 88.20% 88.69% +0.49%
==========================================
Files 99 100 +1
Lines 1713 1752 +39
Branches 396 405 +9
==========================================
+ Hits 1511 1554 +43
+ Misses 202 198 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
buberdds
force-pushed
the
buberdds/multi
branch
2 times, most recently
from
794851b to
2372443
Compare
lukaw3d
reviewed
Sep 7, 2022
lukaw3d
approved these changes
Sep 9, 2022
Contributor
lukaw3d
left a comment
lukaw3d
left a comment
There was a problem hiding this comment.
Great! Just split the first commit and combine some others
buberdds
force-pushed
the
buberdds/multi
branch
from
ad66457 to
ef162b9
Compare
lukaw3d
reviewed
Oct 20, 2022
|
|
||
| import { transactionActions } from '.' | ||
| import { sign } from '../ledger/saga' | ||
| import { sign } from '../importaccounts/saga' |
Contributor
There was a problem hiding this comment.
I didn't notice before, this ledger-specific sign function is now oddly named / oddly placed
Contributor
Author
There was a problem hiding this comment.
indeed, should sign and getUSBTransport generator functions be moved to app/lib/ledger.ts ?
Contributor
There was a problem hiding this comment.
yep
maybe also have fewer ledger sign functions?
- sign from ../importaccounts/saga calls
- OasisTransaction.signUsingLedger calls
- LedgerSigner.sign calls
- OasisApp.sign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82
Most of this stuff was extracted or moved from "ledger". FromLedgerModal is now called MultiAccountsSelectionModal, redux part was renamed as well as it's not longer bound to ledger.