Fix importing and reselecting the same account and cleanup

[lukaw3d]

Fixes #980 (comment)

[github-actions]

MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ EDITORCONFIG	editorconfig-checker	4		0	0.02s
✅ GIT	git_diff	yes		no	0.01s
✅ TYPESCRIPT	eslint	4	0	0	6.46s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

[codecov]

Codecov Report

Merging #984 (2381e00) into master (9e38502) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 2381e00 differs from pull request most recent head ce24369. Consider uploading reports for the commit ce24369 to get more accurate results

@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
+ Coverage   88.73%   88.78%   +0.05%     
==========================================
  Files         100      100              
  Lines        1757     1748       -9     
  Branches      407      405       -2     
==========================================
- Hits         1559     1552       -7     
+ Misses        198      196       -2     

Flag	Coverage Δ
cypress	60.58% <100.00%> (+0.31%)	⬆️
jest	79.71% <71.42%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/app/state/wallet/index.ts	78.94% <100.00%> (+6.22%)	⬆️
src/app/state/wallet/saga.ts	98.38% <100.00%> (-0.15%)	⬇️

[buberdds]

re-importing of a wallet does not work without walletSelected. if we want to get rid of it we should handle that via selectWallet

[lukaw3d]

I'm not sure what you mean. Yes, re-importing of a wallet does not work, either way. This is not an attempt to fix it tho.

And an ugly way to fix it remains possible:

  if (selectImmediately) {
    yield* put(walletActions.selectWallet(undefined))
    yield* put(walletActions.selectWallet(walletId))
  }

[buberdds]

Yes, please include this action if you want to remove walletSelected.

[lukaw3d]

Added back selecting undefined as a quickfix.

Larger solutions:

• when importing: disable checkboxes for existing accounts
• remove useRouteRedirects and redirect in import components

[buberdds]

not sure it's wip or ready for review, but reselecting is still failing for me for a mnemonic and ledger, but works for a priv key.

[lukaw3d]

oh, it's supposed to work :/

[lukaw3d]

Alright, it's ready now.
I'll simplify into these commits after review:

Remove unused walletLoaded action
Deduplicate walletSelected and selectWallet
Don't keep selectImmediately in wallet state
Deduplicate selecting wallet by using selectImmediately
Test importing multiple accounts
Test reimporting and reselecting the same accounts
Fix reimporting and reselecting the same accounts

[buberdds]

ouch, can you add a comment that this is used to avoid React batch updates?

[lukaw3d]

yep yep

Tho I'm not sure why this would be batched in react 17 🤷