Upgrade rubocop to version 0.58.1 #398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've upgraded a dependency and got test failures.
It looks like this version isn't compatible with your project right now. Please take a look at the exact failure to figure out if this is something you need to work on.
What changed?
✳️ rubocop ( → 0.58.1) · Repo · Changelog
Release Notes
From the Github release:
Bug fixes
Style/MethodCallWithArgsParentheseswhen arguments are method calls. (@maxh)Style/RedundantParentheseswith hash literal as first argument tosuper. (@maxh)Gemspec/OrderedDependencieswhen using method call to gem names in gemspec. (@koic)Rails/BulkChangeTableaware of variable table name. (@wata727)Layout/MultilineAssignmentLayoutcop when using multi-line block defines on separate lines. (@koic)Commits
See the full diff on Github. The new version differs by 9 commits:
Cut 0.58.1[Fix #6092] Don't use the broken parser 2.5.1.1 version[Fix #6071] Fix MethodCallWithArgsParentheses when args are method calls (#6083)[Fix #6089] Make `Rails/BulkChangeTable` aware of variable table name (#6090)[Fix #6088] Fix an error for `Layout/MultilineAssignmentLayout`Fix `Style/RedundantParentheses` with hash literal as first argument to `super` (#6085)[Fix #6086] Fix an error for `Gemspec/OrderedDependencies`Add reference to doc of `Performance/RegexpMatch`Move `ContextCreatingMethods` and `MethodCreatingMethods` to default.ymlDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.