Upgrade rubocop to version 0.58.0 #396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've upgraded a dependency and all tests pass. \o/
You should probably take a good look at this before merging this pull request, of course.
What changed?
✳️ rubocop ( → 0.58.0) · Repo · Changelog
Commits
See the full diff on Github. The new version differs by 54 commits:
Cut 0.58Suppress backtrace when usage of `rubocop` command is incorrect[Fix #6067] Prevent auto-correct error for `Performance/InefficientHashSearch`[Fix #2743] Support << besides = in EndAlignmentUpdate Performance/Sample to register offenses when shuffle is followed with at or sliceRefactor corrector specs and check for correct range source in corrector, refs #6049[Fix #4882] Use `IndentationWidth` of `Layout/Tab` for other copsUpdate code review SaaS Sider[Fix #6035] Return correct `Range` in autocorrection of `Layout/LeadingBlankLines`[Fix #6052] Fix a false positive for `Style/SymbolProc`Merge pull request #6056 from drn/create-table-with-timestampsAllow string timestamps in CreateTableWithTimestamps.Merge pull request #6055 from bquorning/circle-ci-status-in-readmeDocument "hidden" ENV variables in Circle configAdd CircleCI status to the README [ci skip]Add CircleCI configurationFix `Lint/RedundantWithObject` error on missing argument to *with_object[Fix #5467] Fix a false negative for `Style/MultipleComparison`Merge pull request #6046 from koic/change_url_of_rubocop_emacs_repoChange URL of rubocop-emacs repoChange README's link from github.com/bbatsov to github.com/rubocop-hqMerge pull request #6026 from kddeisz/exclude-refine[Fix #6029] Fix false positive for `Lint/ShadowedArgument` (#6038)[Fix #6036] Make `Rails/BulkChangeTable` aware of string table nameExclude `refine` by default on BlockLength[Fix #3299] Warn for private_class_method without arguments.Add more test cases for private_class_method usageRefactor IneffectiveAccessModifier cop.Fix incorrect autocorrect for `Style/UnneededCondition`Fix exception when auto-correction UnneededCondition[Fix #6027] Fix Style/IpAddresses choking on an empty string (#6028)Add missing examples for Range include and Style Encoding cops[Fix #4878] Fix false positive in `Layout/IndentationWidth` cop (#5996)Fix auto-correct support check for custom cops on --auto-gen-config[Fix #5973] Add Style/IpAddresses copMerge pull request #6019 from travelerspb/add-missing-style-endblock-exampleAdd missing example for Style EndBlock documentationImprove usage of offense matchers and heredocs in specsFix CHANGELOG.mdDrop support for MRI 2.1Add `bin/setup` script to bin dirMake a few notes in the manual stand out moreEnable the admonition markdown extensionUpdate the manual links to use our new domain rubocop.orgAdd SemVer compatibility badgeUpdate the team section[Fix #5966] Fix a false positive for `Layout/ClosingHeredocIndentation`Remove `rake repl` taskFix small typo[Fix #5987] Suppress errors when using ERB templateMerge pull request #5997 from Bazay/patch-1Fix markdown for UnneededSplatExpansion lintMove a couple of changelog entries[Fix #5843] Add EnforcedStyleForLeadingUnderscores to MemoizedInstanceVariableName (#5844)Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.