add support for private_key_jwt and tls_client_auth #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 966
💛 - Coveralls |
pboling
reviewed
Jan 27, 2020
| when :tls_client_auth | ||
| apply_client_id(params) | ||
| when :private_key_jwt | ||
| params |
Member
There was a problem hiding this comment.
@SteveyblamFreeagent just straight params? The comment on line 49 appears to imply that apply_client_id would be used for private_key_jwt also.
Author
There was a problem hiding this comment.
Thanks for looking at this Peter. Straight params is expected behaviour as private_key_jwt wraps up the client_id in the assertion so it's not passed in the request body. But you're absolutely right the comment was from a previous commit where I was applying the client_id. I'll change the comment now.
Many thanks
fix incorrect assertion in authenticator_spec updates expected debugging output to include INFO instead of DEBUG reduces specificity of test on debug output to allow for the difference between ruby versions corrects text for authenticator_spec Updates comments in authenticator to reflect apply_client_id not being used for private_key_jwt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent merge to master added support for tls_client_auth scheme by providing an auth scheme value that would only add the client_id to the request body. The Private Key JWT scheme includes the client_id in the client_assertion and so is not needed in the main request body.
This PR simply returns unaltered params when private_key_jwt is specified as the auth_scheme and adds tls support for v1.4
I have also dropped the INFO/DEBUG from the client spec as it appears to switch between the two depending on the ruby version. I thought this was neater and simpler than writing a complex set of contexts for different versions. Especially considering that the important aspect is the output information rather than the label.