New version of faraday (1.1.0) broke the build #529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1056
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 1056
💛 - Coveralls |
Contributor
Author
|
Closed in favor of #530. |
1 similar comment
Contributor
Author
|
Closed in favor of #530. |
Contributor
Author
|
Closed in favor of #530. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tested your project with an updated dependency and the build failed.
This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.
Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.
If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)
We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of faraday for this test run.
What changed?
✳️ faraday (>= 0.8, < 2.0 → 1.1.0) · Repo · Changelog
Release Notes
1.1.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 22 commits:
Version bump to 1.1.0Upgrade CI to ruby/setup-ruby (#1187)Remove retry_change_requests from documentation (#1185)Drop `git ls-files` in gemspec (#1183)Include request info in exceptions raised by RaiseError Middleware (#1181)Fix linting bumping Rubocop to 0.90.0 (#1182)Improves documentation on how to contribute to the site by using Docker. (#1175)Properly fix test failure with Rack 2.1+.Introduces `flat_encode` option for multipart adapter. (#1163)Makes parameters sorting configurable (#1162)Update `typhoeus` to new stable version (`1.4`) (#1159)Rubocop linting with 0.84.0 (#1160)Avoid 'last arg as keyword param' warning when building user middleware on Ruby 2.7 (#1153)Limits net-http-persistent version to < 4.0 (#1156)Add 1.0 release to wording in CONTRIBUTING (#1155)Return tests of `Test` adapterAdd EditorConfig fileUpdate RuboCopFix typo for RSpecUpdate year markers to 2020 for a lively lookLink from GitHub Actions badge to CI workflow (#1141)Remove Codeclimate coverage badgeDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands