Skip to content

Conversation

@tuunit
Copy link
Member

@tuunit tuunit commented Feb 9, 2025

Motivation and Context

I want to get rid of the wrapper github.com/ghodss/yaml dependency for the upstream gopkg.in/yaml package inside oauth2-proxy.

I quote:

In short, this library first converts YAML to JSON using go-yaml and then uses json.Marshal and json.Unmarshal to convert to or from the struct. This means that it effectively reuses the JSON struct tags as well as the custom JSON methods MarshalJSON and UnmarshalJSON unlike go-yaml. For a detailed overview of the rationale behind this method

How Has This Been Tested?

  • Extended the unit tests for json & yaml tags
  • Made sure old json tests still work
  • Made sure new yaml tests work as well

@tuunit tuunit force-pushed the feat/yaml-tag-support-and-golang-bump-1.22 branch from 8c1b479 to 300d9c3 Compare February 9, 2025 17:53
@tuunit tuunit force-pushed the feat/yaml-tag-support-and-golang-bump-1.22 branch from 300d9c3 to 7d57b5c Compare February 9, 2025 17:54
@tuunit tuunit requested a review from JoelSpeed February 9, 2025 17:55
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuunit tuunit merged commit 233c0d3 into main Feb 11, 2025
2 checks passed
@tuunit tuunit deleted the feat/yaml-tag-support-and-golang-bump-1.22 branch February 11, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants