Refresh token expiresAt bug

[steffansluis]

I was looking here, and it seems that the check to see if the refresh token has expired checks if the expiry date is in the future, whereas it should check if it is in the past. This seems like a bug to me.

[visvk]

It's not a bug. explanation But you're right, there is something wrong with the RefreshTokenGrantType.RevokeToken function.
RevokeToken should return a boolean rather than an expired token.
There is an open PR #274 that solves this issue.

[steffansluis]

@visvk I see, the idea behind the greater than check is that revokeToken should expire the token, so the token that it returns should always be expired. However, I'm guessing the most common implementation of revokeToken will be a function that removes the token from a database, effectively rendering it expired, so a boolean return value seems fine to me! 👍