update packages #511
Closed
update packages #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2018
Merged
compwright
reviewed
Aug 3, 2018
compwright
left a comment
compwright
left a comment
There was a problem hiding this comment.
There are a few updates that could still be done, and jshint needs to be replaced with eslint to eliminate all security vulnerabilities (see output of npm audit).
| "type-is": "^1.6.15" | ||
| }, | ||
| "devDependencies": { | ||
| "jshint": "2.9.4", |
There was a problem hiding this comment.
This will still cause security warnings from npm audit. jshint has old dependencies and hasn't released a version in a while - it's probably not maintained anymore. I recommend replacing with eslint.
| "type-is": "1.6.15" | ||
| "basic-auth": "^2.0.0", | ||
| "bluebird": "^3.5.0", | ||
| "lodash": "^4.17.4", |
There was a problem hiding this comment.
There is a later version available - maybe bump to 4.18?
| "bluebird": "^3.5.0", | ||
| "lodash": "^4.17.4", | ||
| "promisify-any": "^2.0.1", | ||
| "statuses": "^1.3.1", |
There was a problem hiding this comment.
In my testing this could go to 1.5 without issue.
Member
Author
|
Working on #508 in preference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github alerted me to a vulnerability in the growl library (used by mocha) so I've taken the opportunity to update all packages.
Will leave this here for a short amount of time before merging, all test are passing but let me know if you see any problems