Feature/23 linked icon #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related issue
|
naoido
requested changes
Mar 26, 2025
| font-weight: 400; | ||
| display: inline-block; | ||
| letter-spacing: 0.05em; | ||
| width: 79px; |
| bottom: -5px; | ||
| left: 50%; | ||
| transform: translateX(-50%); | ||
| width: 120px; |
| }, | ||
| }; | ||
|
|
||
| export const Blog2: Story = { |
There was a problem hiding this comment.
Blog1→Default
Blog2→HeaderLinkIsActive
みたいな命名にして、この2つだけでも十分かも！
俺が全部書いてっていっちゃったのが良くなった
| @@ -0,0 +1,19 @@ | |||
| .language-label { | |||
| width: auto; | |||
| font-family: 'Tilt Warp'; | |||
There was a problem hiding this comment.
ここごめーんFigmaでミスフォント選択してた＞＜
Noto Sanas JPに修正したからfont-family消しといて、
基本NotoSansJP以外使わない方針だから、もしこう言うのあったらdiscordで聞いてほしい！
font-weightを900にしといて！
| } | ||
|
|
||
| .Button-label { | ||
| font-family: 'Noto Sans JP'; |
There was a problem hiding this comment.
大元のcssでNoto Sans JP指定してあるからフォントの指定はしなくていいよ！！
後々別のフォント適応する場合にも変えやすいようにfont-familyの指定はコンポーネントごとには基本しなくて大丈夫！
| @@ -0,0 +1,18 @@ | |||
| .Button-link { | |||
| width: 188px; | |||
There was a problem hiding this comment.
ここ文字数が多くなってもはみさないようにmin-widthに変更しといて！
|
|
||
| .Button-label { | ||
| font-family: 'Noto Sans JP'; | ||
| width: 97px; |
There was a problem hiding this comment.
文字数によって横幅変えたいからここのwidthの指定はいらない！
| }, | ||
| }; | ||
|
|
||
| export const Detail2: Story = { |
There was a problem hiding this comment.
あんまり1、2みたいな命名は良くないから
Detail1→Detail
Detail2→DetailWithOutlined
みたいな感じかな！
チーム開発では命名でどんな要素かわかるような命名が大事！
app/root.tsx
Outdated
| { | ||
| rel: "stylesheet", | ||
| href: "https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined", | ||
| }, |
Deploying object-t-website-dev-storybook with
|
| Latest commit: |
02a977a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ce8c2e7.object-t-website.pages.dev |
| Branch Preview URL: | https://feature-23-linked-icon.object-t-website.pages.dev |
naoido
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連チケット
変更内容
動作確認
その他