NullPointer on missing Location header

[neroux]

Hi @igr,

I just got the following stacktrace.

java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.String.trim()' on a null object reference
       at jodd.http.HttpRequest.set(HttpRequest.java)
       at jodd.http.HttpRequest.send(HttpRequest.java:36)

The issue seems to have been that Jodd understood it received a redirect but apparently did not receive a Location header, hence it passed null to set() which then threw a NullPointer

jodd-http/src/main/java/jodd/http/HttpRequest.java

Line 888 in d359c65

set(httpResponse.location());

It would appear as if Location was not sent with all 300s, and even then, it actually seems to be an optional header in general.

[igr]

I assume we may stop with the redirection (as no Location is set) and return the response?

Thank you for reporting!

[neroux]

I assume we may stop with the redirection (as no Location is set) and return the response?

Either that or throw an HttpException, similar to

jodd-http/src/main/java/jodd/http/HttpRequest.java

Line 895 in d359c65

throw new HttpException("Max number of redirects exceeded: " + this.maxRedirects);

I guess I slightly prefer stopping and returning the response as there was no error per se (the header is not required), on the other hand one might argue he wouldn't expect a 300 response when followRedirects is true.

Both are valid point of views IMHO, though I'd still tend to go more with stop and return.

[igr]

Agree, this was a valid state, hence we should break the loop. Yap!

[igr]

6.0.8. released :)

[neroux]

Thanks 🥳