feat: migrated all the noop_value to correct custom data type in the common module and lint fixes too

Author: ashish1099

modules/enableit/common/manifests/backup/gitea.pp

@@ -5,8 +5,8 @@
 # @param noop_value Optional boolean value for noop mode. Defaults to undef.
 #
 class common::backup::gitea (
-  Boolean $enable = false,
-  Optional[Boolean] $noop_value = undef,
+  Boolean               $enable = false,
+  Eit_types::Noop_Value $noop_value = undef,
 ) {
 
   file { '/opt/obmondo/bin/gitea-backup':

modules/enableit/common/manifests/convenience/bash.pp

@@ -5,8 +5,8 @@
 # @param noop_value Whether to perform no-operation. Defaults to false.
 #
 class common::convenience::bash (
-  Boolean           $manage     = true,
-  Optional[Boolean] $noop_value = false,
+  Boolean               $manage     = true,
+  Eit_types::Noop_Value $noop_value = undef,
 ) {
   file {
     default:

modules/enableit/common/manifests/convenience/tmux.pp

@@ -5,8 +5,8 @@
 # @param noop_value Optional Boolean for noop operations. Defaults to false.
 #
 class common::convenience::tmux (
-  Boolean           $manage     = true,
-  Optional[Boolean] $noop_value = false,
+  Boolean               $manage     = true,
+  Eit_types::Noop_Value $noop_value = undef,
 ) {
 
   package::install('tmux')

modules/enableit/common/manifests/logging/journal.pp

@@ -15,7 +15,7 @@
   Boolean                  $upload_enable = false,
   String                   $package_name  = 'systemd-journal-remote',
   Optional[Eit_types::URL] $remote_url    = undef,
-  Optional[Boolean]        $noop_value    = undef,
+  Eit_types::Noop_Value    $noop_value    = undef,
 ) inherits ::common::system::systemd {
   if $manage {
     include ::profile::logging::journal

modules/enableit/common/manifests/mail.pp

@@ -84,7 +84,7 @@
   Hash[String, String] $aliases                              = {},
   Hash[String, String] $_extra_main_parameters               = {},
   Variant[Stdlib::Filemode,String] $maildrop_perms           = 'u+rwX,g-r,g+wX',
-  Optional[Boolean] $noop_value                              = undef,
+  Eit_types::Noop_Value $noop_value                          = undef,
 ) {
   $real_soft_bounce = to_yesno($soft_bounce)
   if $manage {

modules/enableit/common/manifests/monitor.pp

@@ -3,8 +3,8 @@
 # @param enable Whether to enable monitoring. Defaults to the value of $::obmondo_monitoring_status.
 #
 class common::monitor (
-  Boolean $enable     = $::obmondo_monitoring_status,
-  Boolean $noop_value = true,
+  Boolean               $enable     = $::obmondo_monitoring_status, #lint:ignore:top_scope_facts
+  Eit_types::Noop_Value $noop_value = undef,
 ) {
   if $enable {
     contain ::monitor

modules/enableit/common/manifests/monitor/exporter.pp

@@ -7,9 +7,9 @@
 # @param config_dir The directory for exporter configuration files. Defaults to '/opt/obmondo/etc/exporter'.
 #
 class common::monitor::exporter (
-  Boolean              $enable     = $common::monitor::enable,
-  Optional[Boolean]    $noop_value = $common::monitor::noop_value,
-  Stdlib::Absolutepath $config_dir = '/opt/obmondo/etc/exporter',
+  Boolean               $enable     = $common::monitor::enable,
+  Eit_types::Noop_Value $noop_value = $common::monitor::noop_value,
+  Stdlib::Absolutepath  $config_dir = '/opt/obmondo/etc/exporter',
 ) {
   file { $config_dir :
     ensure => ensure_dir($enable),

modules/enableit/common/manifests/monitor/prometheus.pp

@@ -20,7 +20,7 @@
   Stdlib::Absolutepath $usershell,
   Stdlib::Fqdn         $server,
 
-  Boolean              $noop_value = $common::monitor::noop_value,
+  Eit_types::Noop_Value $noop_value = $common::monitor::noop_value,
 ) {
   File {
     noop => $noop_value,

modules/enableit/common/manifests/monitor/prometheus/server.pp

@@ -16,8 +16,8 @@
   Stdlib::Absolutepath $config_dir,
   Eit_types::IPPort    $listen_address,
 
-  Boolean              $enable     = $common::monitor::enable,
-  Boolean              $noop_value = $common::monitor::noop_value,
+  Boolean               $enable     = $common::monitor::enable,
+  Eit_types::Noop_Value $noop_value = $common::monitor::noop_value,
 ) {
 
   include common::monitor::prometheus

modules/enableit/common/manifests/monitoring/scom.pp

@@ -15,7 +15,7 @@
   Optional[Array[Stdlib::Host]] $scom_masters       = undef,
   Boolean                       $install_sudo_rules = true,
   Eit_types::User               $scom_user          = 'svclinuxmon',
-  Boolean                       $noop_value         = undef,
+  Eit_types::Noop_Value         $noop_value         = undef,
 ) {
   if $enable {
     include profile::monitoring::scom