chore: replace the sudoers manage logic without using lookup, by directly setting in common

Signed-off-by: Sidharth Jawale <sidharth@obmondo.com>

Author: VILJkid

.puppet-lint.rc

@@ -3,4 +3,5 @@
 --no-140chars-check
 --no-parameter_order-check
 --no-top_scope_facts
---no-strict_indent
+--no-strict_indent
+--no-file_ensure

modules/enableit/common/data/common.yaml

@@ -192,6 +192,7 @@ common::system::authentication::ignore_expired_root_password: false
 common::system::authentication::purge_ubuntu_user: false
 common::system::authentication::purge_user: false
 
+common::system::authentication::sudo::manage: true
 common::system::authentication::sudo::purge: false
 
 ### DNS

modules/enableit/common/data/os/Debian.yaml

@@ -198,4 +198,3 @@ common::system::authentication::pam::password_session_lines:
 
 common::monitor::prometheus::env_file_path: "/etc/default"
 common::monitor::exporter::security::enable: true
-common::system::authentication::sudo::manage: true

modules/enableit/common/manifests/system/authentication/sudo.pp

@@ -1,5 +1,7 @@
 # @summary Class for managing the sudo settings in the common system authentication
 #
+# @param manage Boolean - If true, will manage the authentication sudo settings. Defaults to true.
+#
 # @param purge Whether to purge existing sudo configurations. Defaults to false.
 #
 # @param ssh_agent_auth Whether to enable SSH agent authentication. Defaults to false.
@@ -9,12 +11,13 @@
 # @param __sudoers_d_dir The absolute path to the sudoers.d directory. Defaults to '/etc/obmondo/sudoers.d'.
 #
 class common::system::authentication::sudo (
+  Boolean $manage          = true,
   Boolean $purge           = false,
   Boolean $ssh_agent_auth  = false,
   Eit_types::Sudoers $sudoers = {},
   Stdlib::Absolutepath $__sudoers_d_dir = '/etc/obmondo/sudoers.d',
 ) {
-  if lookup('common::system::authentication::sudo::manage', Boolean, undef, true) {
+  if $manage {
     include profile::system::sudoers
   }
 }

modules/enableit/monitor/manifests/system/hwmon.pp

@@ -5,13 +5,13 @@
 class monitor::system::hwmon (
   Boolean $enable = true,
 ) {
-  if dig($facts, 'dmi', 'board', 'product') == 'PRIME X670-P WIFI' {
+  if $facts['dmi']['board']['product'] == 'PRIME X670-P WIFI' {
     file { '/etc/modprobe.d/nct6775.conf':
-      ensure  => 'file',
+      ensure  => 'present',
       content => 'options nct6775 force_id=0xd420',
     }
     file { '/etc/modules-load.d/nct6775.conf':
-      ensure  => 'file',
+      ensure  => 'present',
       content => 'nct6775',
     }
   }