Skip to content

Solve issue with completeness check that fails on empty data #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Solve issue with completeness check that fails on empty data #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9500075
Fixed completeness check for zero expected lines
AssafBenDavid Apr 7, 2023
f86c0b9
Merge branch 'main' of github.com:cr-assafbendavid/observe-export int…
AssafBenDavid Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions observe_export/observe_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,9 +585,9 @@ def get_crawling_command(start_time: datetime, end_time: datetime, output_file:
f"Was expecting to find exactly one csv file with the correctness data but found multiple: {files_downloaded}")
correctness_file = files_downloaded[0]
if crawling_format == Format.CSV:
expected_number_of_lines = pd.read_csv(correctness_file, header=0)["count"][0]
expected_number_of_lines = pd.read_csv(correctness_file, header=0)["count"].get(0, 0)
else:
expected_number_of_lines = pd.read_json(correctness_file, lines=True)["count"][0]
expected_number_of_lines = pd.read_json(correctness_file, lines=True)["count"].get(0, 0)
_, number_of_lines_exported = get_first_line_and_line_count(main_result_file)
if expected_number_of_lines == number_of_lines_exported:
print("\tCompleteness check passed!\n\t\t all rows were exported!")
Expand Down