-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Remove duplicate missing files code #5148
Conversation
a02ce8d
to
c18a457
Compare
c18a457
to
5d1ea56
Compare
There was a bug that the missing file dialog cannot catch missing files on transitions. However, this PR fixed the issue. The step to reproduce the bug is as below.
I've made another PR #6753 but the PR #6753 is unnecessary if this PR is merged. |
5d1ea56
to
31081d8
Compare
The same code was in different places, so call single function to clean up code.
31081d8
to
363193f
Compare
I'm afraid this change is dangerous in terms of thread safety. Prior to this change, the sources have not been revealed to the graphics thread when checking the missing files. Now, the missing files are checked after the graphics thread started to access the sources. The graphics thread also touch the data when Especially, some sources such as I'd like to suggest reverting this change and also do not call |
With obsproject#5148, it was brought up that the loading of the missing files was not thread safe. This PR fixes that problem, while still simplifying the original missing files code.
With obsproject#5148, it was brought up that the loading of the missing files was not thread safe, as the missing files were being loaded late in the loading process. This PR tries to fix that problem, while still simplifying the original missing files code.
With obsproject#5148, it was brought up that the loading of the missing files was not thread safe, as the missing files were being loaded late in the loading process. This PR tries to fix that problem, while still simplifying the original missing files code.
With #5148, it was brought up that the loading of the missing files was not thread safe, as the missing files were being loaded late in the loading process. This PR tries to fix that problem, while still simplifying the original missing files code.
Description
The same code was in different places, so call single function to
cleanup code.
Motivation and Context
Code cleanup.
How Has This Been Tested?
Tested with missing files to make sure dialog still worked properly.
Types of changes
Checklist: