Refactor value and type diffs (#100)

NchamJosephMuam · web-flow · commit bc6c4a756ba9 · 2024-10-21T17:19:55.000+02:00
* refactor value and type diffs

* refactor
diff --git a/lib/text_diff.ml b/lib/text_diff.ml
@@ -41,29 +41,18 @@ let md_to_lines name md =
   let module_str = "module " ^ name ^ ": " ^ Buffer.contents buf in
   CCString.lines module_str
 
-let process_value_diff (val_diff : Diff.value) =
-  match val_diff.vdiff with
-  | Added vd -> [ { orig = []; new_ = vd_to_lines val_diff.vname vd } ]
-  | Removed vd -> [ { orig = vd_to_lines val_diff.vname vd; new_ = [] } ]
+let process_diff (diff : (_, _ Diff.atomic_modification) Diff.t) name to_lines =
+  match diff with
+  | Added item -> [ { orig = []; new_ = to_lines name item } ]
+  | Removed item -> [ { orig = to_lines name item; new_ = [] } ]
   | Modified { reference; current } ->
-      [
-        {
-          orig = vd_to_lines val_diff.vname reference;
-          new_ = vd_to_lines val_diff.vname current;
-        };
-      ]
+      [ { orig = to_lines name reference; new_ = to_lines name current } ]
+
+let process_value_diff (val_diff : Diff.value) =
+  process_diff val_diff.vdiff val_diff.vname vd_to_lines
 
 let process_type_diff (type_diff : Diff.type_) =
-  match type_diff.tdiff with
-  | Added td -> [ { orig = []; new_ = td_to_lines type_diff.tname td } ]
-  | Removed td -> [ { orig = td_to_lines type_diff.tname td; new_ = [] } ]
-  | Modified { reference; current } ->
-      [
-        {
-          orig = td_to_lines type_diff.tname reference;
-          new_ = td_to_lines type_diff.tname current;
-        };
-      ]
+  process_diff type_diff.tdiff type_diff.tname td_to_lines
 
 let from_diff (diff : Diff.module_) : t =
   let rec process_module_diff module_path (module_diff : Diff.module_) acc =
