used int exit codes

Siddhi-agg · NathanReb · commit dc6af5972276 · 2024-08-23T12:46:05.000+02:00
diff --git a/bin/api_diff.ml b/bin/api_diff.ml
@@ -25,7 +25,7 @@ let run (`Ref_cmi reference) (`Current_cmi current) =
       ~current:current_sig
   in
   match diff with
-  | None -> Ok ()
+  | None -> Ok 0
   | Some diff ->
       let text_diff = Api_watch.Text_diff.from_diff diff in
       let print_module_diff module_path diff =
@@ -34,7 +34,7 @@ let run (`Ref_cmi reference) (`Current_cmi current) =
         Printf.printf "\n"
       in
       Api_watch.String_map.iter print_module_diff text_diff;
-      Ok ()
+      Ok 1
 
 let named f = Cmdliner.Term.(app (const f))
 
@@ -60,5 +60,5 @@ let info =
 let term = Cmdliner.Term.(const run $ ref_cmi $ current_cmi)
 
 let () =
-  let exit_code = Cmdliner.Cmd.eval_result (Cmdliner.Cmd.v info term) in
+  let exit_code = Cmdliner.Cmd.eval_result' (Cmdliner.Cmd.v info term) in
   exit exit_code
diff --git a/tests/api-diff/run.t b/tests/api-diff/run.t
@@ -49,6 +49,7 @@ Run api-watcher on the two cmi files, there should be a difference
   diff module Add_type:
   
   +<unsupported change>
+  [1]
 
 ### A file with a removed type:
 
@@ -67,6 +68,7 @@ Run api-watcher on the two cmi files, there should be a difference
   diff module Remove_type:
   
   +<unsupported change>
+  [1]
 
 ### A file with a modified type:
 
@@ -86,6 +88,7 @@ Run api-watcher on the two cmi files, there should be a difference
   diff module Modify_type:
   
   +<unsupported change>
+  [1]
 
 ## Different .cmi files for value tests:
 
@@ -107,6 +110,7 @@ Run api-diff and check the output
   diff module Add_value:
   
   +val g : t -> t
+  [1]
 
 ### Removing a value:
 
@@ -124,6 +128,7 @@ Run api-diff and check the output
   diff module Remove_value:
   
   -val f : t -> string
+  [1]
 
 ### Modifying a value:
 
@@ -143,6 +148,7 @@ Run api-diff and check the output
   
   -val f : t -> string
   +val f : t -> t
+  [1]
 
 Here we generate a `.mli` file with a module:
 
@@ -177,6 +183,7 @@ Run api-diff and check the output
   diff module Add_module:
   
   +module N: sig val y : float end
+  [1]
 
 ### Removing a module:
 
@@ -193,6 +200,7 @@ Run api-diff and check the output
   diff module Remove_module:
   
   -module M: sig val x : int end
+  [1]
 
 ### Modifying a module:
 
@@ -211,6 +219,7 @@ Run api-diff and check the output
   
   -val x : int
   +val x : float
+  [1]
 
 Generate a new .mli file with values and submodules
   $ cat > orig_module.mli << EOF
@@ -258,6 +267,7 @@ Run api-diff and check the output
   -val g : int -> string
   +val g : int -> (string, string) result
   
+  [1]
 
 Create the first version of a simple project
   $ mkdir -p project_v1/lib
@@ -367,3 +377,4 @@ Run the api-diff tool on the two project versions
   diff module project_v2.Mylib__Utils:
   +val triple : int -> int
   
+  [1]
