Skip to content

Conversation

@beobillly
Copy link
Contributor

issue #202

I propose this solution.
It works on different size and with mobile format. Buttons are placed on top of the toplevel pane so they are always visible.

the toplevel input has been moved at the bottom of the window

toplevelplacement

toplevelplacement2

@yurug
Copy link
Collaborator

yurug commented Jun 11, 2019

There is a risk that the buttons hide the text, right?

@beobillly
Copy link
Contributor Author

It's automatically resized depending on the size of the screen.
The buttons can't hide the text. At worst they are just above it.
If you found it's too close I can arrange that.

Also I just found out that I did that for the toplevel of the Exercise menu but not for the toplevel of Activities menu, would you like me to do the same for it ?

toplevel of Activities
toplevel of activities

toplevel of Exercises
toplevel of exercise

@beobillly
Copy link
Contributor Author

I changed the placement of the Activities toplevel buttons at the same place than the Exercices.

@yurug
Copy link
Collaborator

yurug commented Jun 19, 2019

Thanks!

@yurug yurug merged commit 3972fe1 into ocaml-sf:master Jun 19, 2019
AltGr added a commit to AltGr/learn-ocaml that referenced this pull request Jul 30, 2021
…evel_buttons"

This reverts commit 3972fe1, reversing
changes made to d5c078c.
AltGr added a commit to AltGr/learn-ocaml that referenced this pull request Jul 30, 2021
…evel_buttons"

This reverts commit 3972fe1, reversing
changes made to d5c078c.
EmileRolley pushed a commit to EmileRolley/learn-ocaml that referenced this pull request Sep 16, 2021
…evel_buttons"

This reverts commit 3972fe1, reversing
changes made to d5c078c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants