Fix and improve the optimization of JavaScript interoperability primitives #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
changed the title
Some optimizations were no longer applied after the array initialization fix in #113. The following functions from `Js.Unsafe` were affected: `call`, `fun_call`, `meth_call` and `new_obj`.
…a key
The OCaml string is converted to a JavaScript string at compile time.
This make us generate better code for the functions
`Ojs.{get,set,delete}_prop_ascii` from gen_js_api.
vouillon
force-pushed
the
js-prim-fixes
branch
from
1b9fcd7 to
59f3462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optimizations were no longer applied after the array initialization fix in #113. The following functions from
Js.Unsafewere affected:call,fun_call,meth_callandnew_obj.The OCaml string is converted to a JavaScript string at compile time. This make us generate better code for the functions
Ojs.{get,set,delete}_prop_asciifrom gen_js_api.