Pin the Docker image version #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricoferris
approved these changes
Sep 27, 2021
Contributor
patricoferris
left a comment
patricoferris
left a comment
There was a problem hiding this comment.
Thanks! I think this will keep the deployments building even with new releases (we can then be a bit more prepared when bumping OCaml version) :))
Member
|
Pinning the OCaml version is a good idea, and takes the pressure off #120 to be merged too soon. Although it is really nice that our release process is now good enough that we can upgrade to 4.13 in such short order! |
TheLortex
pushed a commit
to TheLortex/v3.ocaml.org-server
that referenced
this pull request
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #120 that pins the docker image. Thanks for the suggestion @patricoferris