Fewer conversions between Names and strings #1177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
force-pushed
the
fewer-name-to-strings
branch
from
328f98c to
67ed47d
Compare
|
Looks good I think. As I'm paranoid though, I'd like to check this by running it on some JS libs before and after this PR to confirm there are no changes. The driver ought to make this simple enough to try. |
|
I've now tested this, and there are a couple of changes in the output, but they're for the better! Both of the form
|
panglesd
added a commit
to panglesd/sherlodoc
that referenced
this pull request
Dec 9, 2024
"Fewer conversions between Names and strings"
panglesd
added a commit
to panglesd/sherlodoc
that referenced
this pull request
Dec 9, 2024
"Fewer conversions between Names and strings"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typed
`Dotconstructors allow to propagate the typed names further. TheFindmodule is changed to avoid converting names to strings in many cases.This is extracted from Jon's
parameterised-pathsbranch