Use expect test for parser tests #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
requested changes
Mar 16, 2021
There was a problem hiding this comment.
Odoc_model.Semantics and Odoc_model.Reference.parse are no longer tested. (which were in the previous version)
They need to be tested too but outside of the "parser" library, maybe in a new test/model directory. A lot of these tests need to move there (the Reference_component_kind section, every tests that contain occurences of warnings defined in src/model/semantics.ml).
Julow
reviewed
Mar 16, 2021
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
lubegasimon
force-pushed
the
use-expect-test-for-parser-tests
branch
from
769f795 to
6e65056
Compare
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
|
I think this is looking good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.