Skip to content

Conversation

@verbosemode
Copy link
Contributor

Syslog message parser

CHANGES:

CHANGES:

* Warning: encode function no longer truncates messages to 1024 bytes by default
* split message part into tag and content (verbosemode/syslog-message#20, by @hannesm)
* use result types instead of option (verbosemode/syslog-message#20, by @hannesm)
* remove transport-dependent length check from encode (verbosemode/syslog-message#20, by @hannesm)
* switch build system to Dune (verbosemode/syslog-message#19, by @dra27)
* add encode_local for sending to local syslog (verbosemode/syslog-message#17, by @dra27)
* forgot to thank @hannesm, @Leonidas-from-XIV for past contributions
@mseri
Copy link
Member

mseri commented Oct 14, 2018

Looks good. Waiting for camelus before merging

@camelus
Copy link
Contributor

camelus commented Oct 14, 2018

☀️ All lint checks passed d2091b9
  • These packages passed lint tests: syslog-message.0.0.3

☀️ Installability check (9789 → 9790)
  • new installable packages (1): syslog-message.0.0.3

@dra27
Copy link
Member

dra27 commented Oct 14, 2018

Small point, but shouldn’t it really be 0.1.0 rather than 0.0.3? Or even take the plunge to 1.0.0, given the interface changes?

@verbosemode
Copy link
Contributor Author

Small point, but shouldn’t it really be 0.1.0 rather than 0.0.3? Or even take the plunge to 1.0.0, given the interface changes?

You're right. It should have been at least a 0.1.0 due to the interface changes. I could still change it, since @hannesm is using >= "0.0.2" as version constraint in his logs-syslog library.

@hannesm
Copy link
Member

hannesm commented Oct 14, 2018

I'm actually using = "0.0.2" in logs-syslog, so I don't mind.

@kit-ty-kate
Copy link
Member

@verbosemode what do you want to do?

@verbosemode
Copy link
Contributor Author

@verbosemode what do you want to do?

I went for option three now and made a 1.0.0 release in PR #12809. I didn't know how to properly edit this one, sorry.

@verbosemode verbosemode deleted the release-syslog-message-0.0.3 branch October 15, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants